Skip to content

Update CMake version #67170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

etcwilde
Copy link
Contributor

@etcwilde etcwilde commented Jul 6, 2023

LLVM requires at least CMake 3.20 on next. Bumping the CMake version to unblock work.

CMake Error at CMakeLists.txt:3 (cmake_minimum_required):
  CMake 3.20.0 or higher is required.  You are running version 3.19.6

LLVM minimum requirement is 3.20 now. Updating the next branch checkout.
@etcwilde
Copy link
Contributor Author

etcwilde commented Jul 7, 2023

@swift-ci please test

@etcwilde
Copy link
Contributor Author

etcwilde commented Jul 7, 2023

Made it past the CMake version failure and into issues in LLVM that are fixed in https://reviews.llvm.org/D154664.
(though half of the below is also due to a leaky architecture)

/Users/ec2-user/jenkins/workspace/swift-PR-macos@2/branch-next/llvm-project/llvm/include/llvm/Support/Format.h:220:3: error: no template named 'optional' in namespace 'std'; did you mean 'Optional'?
  220 |   std::optional<uint64_t> FirstByteOffset;
      |   ^~~~~~~~~~~~~
      |   Optional
/Users/ec2-user/jenkins/workspace/swift-PR-macos@2/branch-next/swift/stdlib/include/llvm/ADT/Optional.h:251:29: note: 'Optional' declared here
  251 | template <typename T> class Optional {
      |                             ^

@edymtt
Copy link
Contributor

edymtt commented Jul 7, 2023

The plan I discussed offline with @shahmishal was to bump to CMake 3.24.2 in main, and have that change propagate to next -- #67018

@shahmishal
Copy link
Member

We can close this PR, I have merged #67018

@etcwilde etcwilde closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants