Update the compiler arguments used for background AST builds #1971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
commented
Feb 6, 2025
|
@swift-ci please test |
ahoppen
approved these changes
Feb 6, 2025
Comment on lines
1303
to
1304
| case .removeOptionAndPreviousArgument: | ||
| _ = result.popLast() |
There was a problem hiding this comment.
Should we validate that the previous argument is indeed -Xfrontend? If it is not, should we log a fault and not remove the argument? Probably best to give removeOptionAndPreviousArgument an associated value with the expected previous argument in that case.
There was a problem hiding this comment.
I skipped the log, seems noisy and if the flag is there then we should remove it regardless (but have skipped removing the previous).
bnbarham
force-pushed
the
pass-allow-errors-for-ast
branch
from
baf8d12 to
29b4e95
Compare
|
@swift-ci please test |
ahoppen
reviewed
Feb 7, 2025
bnbarham
force-pushed
the
pass-allow-errors-for-ast
branch
from
29b4e95 to
25548d5
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
This fixes two issues: 1. The SwiftPM build system was setup without passing through whether it should prepare or not. This meant that we lost eg. the argument to allow compiler errors when building the AST (even though it was set when building the modules) 2. The compiler argument adjustment to remove harmful and unnecessary flags only applied to indexing arguments, not those passed to the AST builds Resolves rdar://141508656.
bnbarham
force-pushed
the
pass-allow-errors-for-ast
branch
from
25548d5 to
ab12429
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
Resolves rdar://141508656.