[6.1] Update the compiler arguments used for background AST builds #1972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bnbarham
commented
Feb 8, 2025
bnbarham
commented
- Explanation: Fixes issues caused by a mismatch between the arguments used during preparation and background ASTs/indexing.
- Scope: Settings handling
- Issue: rdar://141508656
- Original PR: Update the compiler arguments used for background AST builds #1971
- Risk: Medium, this is a non-trivial change to settings handling. However, this is a well tested area (many tests are really integration tests using a SwiftPM project) and the alternative (crashes, loss of functionality, etc) is much worse.
- Testing: Added a test case for a direct use of an invalid function.
- Reviewer: @ahoppen
This fixes two issues: 1. The SwiftPM build system was setup without passing through whether it should prepare or not. This meant that we lost eg. the argument to allow compiler errors when building the AST (even though it was set when building the modules) 2. The compiler argument adjustment to remove harmful and unnecessary flags only applied to indexing arguments, not those passed to the AST builds Resolves rdar://141508656. (cherry picked from commit ab12429)
|
@swift-ci please test |
|
@swift-ci Please test Windows |
ahoppen
approved these changes
Feb 10, 2025
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.