Use the new SwiftPM API to load the build plan #1973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
force-pushed
the
generated-source-should-work
branch
from
3e7ca95 to
0c4c75c
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
|
Will need to update this to only build plugins when background indexing is enabled so that we don’t conflict with the regular build directory. |
bnbarham
force-pushed
the
generated-source-should-work
branch
from
0c4c75c to
1d65ff0
Compare
bnbarham
force-pushed
the
generated-source-should-work
branch
from
1d65ff0 to
95e49b5
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
|
swiftlang/swift-package-manager#8286 @swift-ci please test Windows platform |
bnbarham
force-pushed
the
generated-source-should-work
branch
from
95e49b5 to
54a1e02
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
|
swiftlang/swift-package-manager#8286 @swift-ci please test Windows platform |
bnbarham
force-pushed
the
generated-source-should-work
branch
2 times, most recently
from
61b34fb to
d762363
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
|
swiftlang/swift-package-manager#8286 @swift-ci please test Windows platform |
bnbarham
force-pushed
the
generated-source-should-work
branch
from
d762363 to
f142b5c
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
bnbarham
force-pushed
the
generated-source-should-work
branch
from
f142b5c to
5f25d6a
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
We previously skipped building/running tool plugins here, which meant that the compiler arguments for a target also missed any generated sources. Use the new `BuildDescription.load` API from SwiftPM to address this. Resolves rdar://102242345.
This *shouldn't* be needed, but allows running plugins to be skipped if there's any unexpected interactions with background indexing.
bnbarham
force-pushed
the
generated-source-should-work
branch
from
5f25d6a to
a534385
Compare
|
swiftlang/swift-package-manager#8286 @swift-ci please test |
|
swiftlang/swift-package-manager#8286 @swift-ci please test Windows platform |
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Mar 11, 2025
Since we re-index source files if the build server sends us a `buildTarget/didChange` notification, we no longer need to wait for an up-to-date build graph when a file is modified. This resolves an issue that causes a `Scheduling tasks` progress to appear in the status bar whenever a file in the project is changed. Before swiftlang#1973, this happened fairly frequently during the initial indexing when a header file was written into the build directory. After that PR the `Scheduling Indexing` status appears a lot more frequently, namely every time the index’s database is modified, which happens quite all the time during indexing...
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Mar 11, 2025
Since we re-index source files if the build server sends us a `buildTarget/didChange` notification, we no longer need to wait for an up-to-date build graph when a file is modified. This resolves an issue that causes a `Scheduling tasks` progress to appear in the status bar whenever a file in the project is changed. Before swiftlang#1973, this happened fairly frequently during the initial indexing when a header file was written into the build directory. After that PR the `Scheduling Indexing` status appears a lot more frequently, namely every time the index’s database is modified, which happens quite all the time during indexing...
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Mar 11, 2025
Since we re-index source files if the build server sends us a `buildTarget/didChange` notification, we no longer need to wait for an up-to-date build graph when a file is modified. This resolves an issue that causes a `Scheduling tasks` progress to appear in the status bar whenever a file in the project is changed. Before swiftlang#1973, this happened fairly frequently during the initial indexing when a header file was written into the build directory. After that PR the `Scheduling Indexing` status appears a lot more frequently, namely every time the index’s database is modified, which happens quite all the time during indexing...
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Mar 11, 2025
… currently happening - **Issue**: Since swiftlang#1973, we are watching for all changes in SourceKit-LSP. This means that we get notified every time the index database is changed. Each of these modifications triggers a new task that waits for build system updates to determine if the modified file needs to be re-indexed. While this task finishes very quickly, it still causes `Scheduling indexing` to replace the `Indexing x / y` in the index status during initial indexing, which looks very noisy. - **Explanation**: To avoid this flickering, only show `Scheduling indexing` in the index status if we aren’t already indexing any files - **Scope**: Index progress status - **Original PR**: This is a significantly reduced version of swiftlang#2051 - **Risk**: Low, this only changes the precedence of status messages in the indexing status - **Testing**: Manually verified that we don’t see `Scheduling indexing` appear during initial indexing of a package - **Reviewer**: @bnbarham
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Mar 11, 2025
Since we re-index source files if the build server sends us a `buildTarget/didChange` notification, we no longer need to wait for an up-to-date build graph when a file is modified. This resolves an issue that causes a `Scheduling tasks` progress to appear in the status bar whenever a file in the project is changed. Before swiftlang#1973, this happened fairly frequently during the initial indexing when a header file was written into the build directory. After that PR the `Scheduling Indexing` status appears a lot more frequently, namely every time the index’s database is modified, which happens quite all the time during indexing...
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Mar 18, 2025
Since we re-index source files if the build server sends us a `buildTarget/didChange` notification, we no longer need to wait for an up-to-date build graph when a file is modified. This resolves an issue that causes a `Scheduling tasks` progress to appear in the status bar whenever a file in the project is changed. Before swiftlang#1973, this happened fairly frequently during the initial indexing when a header file was written into the build directory. After that PR the `Scheduling Indexing` status appears a lot more frequently, namely every time the index’s database is modified, which happens quite all the time during indexing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously skipped building/running tool plugins here, which meant that the compiler arguments for a target also missed any generated sources. Use the new
BuildDescription.loadAPI from SwiftPM to address this.Fixes #665
Resolves rdar://102242345.
Resolves rdar://144557689.