Re-work the mixins for swiftpm and downstream packages #79380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
bkhouri
approved these changes
Feb 14, 2025
Keep mixin_swiftpm_base as the base of SwiftPM and all dependents, but then separate the SwiftPM + package bases and their respective platforms. This allows SwiftPM to add its own changes without impacting downstream packages (eg. the recently added cross compile setting).
bnbarham
force-pushed
the
update-some-presets
branch
from
8d92911 to
f0c6282
Compare
bnbarham
changed the title
|
I misread the mixins initially :(. Re-worked them a little now. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep mixin_swiftpm_base as the base of SwiftPM and all dependents, but then separate the SwiftPM + package bases and their respective platforms.
This allows SwiftPM to add its own changes without impacting downstream packages (eg. the recently added cross compile setting).