Fix CMake build by adding missed new files to CMakeLists #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are files that were added in #668. |
|
@swift-ci test |
|
Linux CI is busted after swiftlang/swift#62552 but @grynspan is on it! |
|
Will re-test after swiftlang/swift#62583 (review) lands. |
|
Thanks. Sorry I forgot that we needed to add the files to CMake |
ahoppen
approved these changes
Dec 14, 2022
|
Can we set up a CMake build on CI? If not on Windows, maybe on Linux at least? This keeps breaking CI on unrelated PRs in other repositories. |
|
@swift-ci please test Linux |
1 similar comment
|
@swift-ci please test Linux |
|
CC: @shahmishal for the additional test configuration (ideally on Windows, but, we should be able to setup this on Linux if necessary). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake build otherwise currently fails.
e.g. https://ci-external.swift.org/job/swift-driver-PR-windows/227/console