Skip to content

[Dependency Scanning] Query scanner whether discovered binary Swift modules are frameworks #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Dec 13, 2022

This info is required so that it can be specified as input to compilation that uses such module as a dependency, in order to decide whether or not to insert an auto-linking directive for it.

Companion change to swiftlang/swift#62540

Part of rdar://102824777

…odules are frameworks

Part of rdar://102824777
@artemcm artemcm force-pushed the BinaryExplicitDependencyFrameworks branch from 591d24a to 3b2ec65 Compare December 13, 2022 18:16
@artemcm
Copy link
Contributor Author

artemcm commented Dec 13, 2022

@swift-ci test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Shouldn't linking be explicit too given that we have all the dependency info?

@artemcm
Copy link
Contributor Author

artemcm commented Dec 13, 2022

LGTM! Shouldn't linking be explicit too given that we have all the dependency info?

It absolutely should. But I'd like to get the existing flow working first, to avoid changing too many systems at-once, and then followup with the explicit linking work.

@artemcm
Copy link
Contributor Author

artemcm commented Dec 13, 2022

@swift-ci test Windows platform

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Dec 13, 2022

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Dec 14, 2022

C:\Users\swift-ci\jenkins\workspace\swift-driver-PR-windows\sourcekit-lsp\Sources\LanguageServerProtocol\Messages\.swift:59:3: error: cannot find 'OpenInterfaceRequest' in scope

This is a new one and is not related to the contents of this PR. @compnerd have we seen this before?

@compnerd
Copy link
Member

Don't think we have. Could be a recent change for LSP? Should check that, but at the very least, we should check the driver build doesn't fail.

@artemcm
Copy link
Contributor Author

artemcm commented Dec 14, 2022

Seems really weird. The reference to this type was added in the same commit as the definition. 🤔

@artemcm
Copy link
Contributor Author

artemcm commented Dec 14, 2022

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Dec 14, 2022

Ohh, I think the CMake build is broken, but not the package build.

@compnerd
Copy link
Member

That doesn't make sense: swiftlang/sourcekit-lsp@c31dff2#diff-9e9107c03ddddab7789c4b0e4591aa6a0c569955404bda08039056526263391dR59 seems that it does update the CMake build.

@artemcm
Copy link
Contributor Author

artemcm commented Dec 14, 2022

That doesn't make sense: apple/sourcekit-lsp@c31dff2#diff-9e9107c03ddddab7789c4b0e4591aa6a0c569955404bda08039056526263391dR59 seems that it does update the CMake build.

swiftlang/sourcekit-lsp#678

@artemcm
Copy link
Contributor Author

artemcm commented Dec 14, 2022

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Dec 15, 2022

Now Windows CI is broken for a new reason. 😥
Waiting on swiftlang/llvm-project#5792 to merge to unblock.

@artemcm
Copy link
Contributor Author

artemcm commented Dec 15, 2022

@swift-ci test Windows platform

@artemcm artemcm merged commit cee8c66 into swiftlang:main Dec 15, 2022
@artemcm artemcm deleted the BinaryExplicitDependencyFrameworks branch December 15, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants