-
Notifications
You must be signed in to change notification settings - Fork 199
[Dependency Scanning] Query scanner whether discovered binary Swift modules are frameworks #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dependency Scanning] Query scanner whether discovered binary Swift modules are frameworks #1240
Conversation
…odules are frameworks Part of rdar://102824777
591d24a
to
3b2ec65
Compare
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Shouldn't linking be explicit too given that we have all the dependency info?
It absolutely should. But I'd like to get the existing flow working first, to avoid changing too many systems at-once, and then followup with the explicit linking work. |
@swift-ci test Windows platform |
1 similar comment
@swift-ci test Windows platform |
This is a new one and is not related to the contents of this PR. @compnerd have we seen this before? |
Don't think we have. Could be a recent change for LSP? Should check that, but at the very least, we should check the driver build doesn't fail. |
Seems really weird. The reference to this type was added in the same commit as the definition. 🤔 |
@swift-ci test Windows platform |
Ohh, I think the CMake build is broken, but not the package build. |
That doesn't make sense: swiftlang/sourcekit-lsp@c31dff2#diff-9e9107c03ddddab7789c4b0e4591aa6a0c569955404bda08039056526263391dR59 seems that it does update the CMake build. |
|
@swift-ci test Windows platform |
Now Windows CI is broken for a new reason. 😥 |
@swift-ci test Windows platform |
This info is required so that it can be specified as input to compilation that uses such module as a dependency, in order to decide whether or not to insert an auto-linking directive for it.
Companion change to swiftlang/swift#62540
Part of rdar://102824777