Skip to content

Only display declaration modified diff when the other declaration list is collapsed #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2024

Conversation

hqhhuang
Copy link
Contributor

Bug/issue #, if applicable: rdar://127126248 ([Overloads][API Changes] Can't show other overload symbols when showing decl diff)

Summary

Only display declaration modified diff when the other declaration list is collapsed

Also in this PR: Changed the name of a component from DeclarationGroup to DeclarationList in preparation of another bug fix. Splitting it off here with this bug since this fix is relatively small and less confusing to review.

Dependencies

NA

Testing

Steps:

  1. Test with an overloaded page with modified changes
  2. Assert that clicking on "Show other declaration" button shows other declarations

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

only show decl diff when list is collapsed
@hqhhuang hqhhuang requested review from mportiz08 and marinaaisa May 23, 2024 17:01
@hqhhuang
Copy link
Contributor Author

@swift-ci test

@hqhhuang
Copy link
Contributor Author

@swift-ci test

Copy link
Member

@marinaaisa marinaaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it looks great. Thanks Hanqing!

@hqhhuang hqhhuang merged commit f68d28e into swiftlang:main May 23, 2024
1 check passed
@hqhhuang hqhhuang deleted the do-not-show-decl-diff-when-expanded branch May 23, 2024 17:28
hqhhuang added a commit to hqhhuang/swift-docc-render that referenced this pull request May 23, 2024
…126248

only show decl diff when list is collapsed (swiftlang#829) rdar://127126248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants