[6.0] Only display declaration modified diff when the other declaration list is collapsed #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hqhhuang
commented
May 23, 2024
hqhhuang
commented
- Explanation: Adds a flag to hide declaration diff when showing the list of overloaded symbols.
- Scope: Impacts overloaded symbol pages with declaration diff
- Issue: rdar://127126248
- Risk: Low, just an additional if statement
- Testing: Manually verify and added test
- Reviewer: @marina
- Original PR: Only display declaration modified diff when the other declaration list is collapsed #829
…126248 only show decl diff when list is collapsed (swiftlang#829) rdar://127126248
|
@swift-ci test |
franklinsch
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.