Some C++ packages fail to build on Apple platforms #7267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-fmodules` doesn't usually do anything in Apple clang for C++ compilation, `-fcxx-modules` needs to be passed as well. However, pure C++ (not Objective-C++) and a new enough dialect on some versions of Apple clang will implicitly enable `-fcxx-modules`, enabling clang modules, and causing errors. Stop passing `-fmodules` for C++ compilation. rdar://121056905
ian-twilightcoder
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci test |
|
@swift-ci smoke test |
|
Related to #7241 |
neonichu
approved these changes
Jan 17, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable clang modules for C++ compilation on Apple platforms
Motivation:
I didn't realize that there were some circumstances where passing
-fmoduleswould enable clang modules for C++ on Apple platforms.Modifications:
Go back to not passing
-fmodulesfor Apple platforms.Result:
C++ packages should be able to build properly again.