Skip to content

Work around SwiftPM build regression affecting packages with C++ targets #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Work around SwiftPM build regression affecting packages with C++ targets #188

wants to merge 1 commit into from

Conversation

stmontgomery
Copy link
Contributor

This is a workaround to the SwiftPM issue being fixed here:

swiftlang/swift-package-manager#7267

@stmontgomery stmontgomery added bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support workaround Workaround for an issue in another component (may need to revert later) labels Jan 17, 2024
@stmontgomery stmontgomery self-assigned this Jan 17, 2024
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

grynspan
grynspan requested changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@grynspan grynspan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that a fix PR is open on SwiftPM and presumably will be merged shortly, I don't think we need to apply a workaround here. We can wait a couple more days.

@stmontgomery
Copy link
Contributor Author

No longer relevant, the SwiftPM bug was fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grynspan grynspan grynspan requested changes

@briancroom briancroom briancroom approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@stmontgomery stmontgomery

Labels
bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support workaround Workaround for an issue in another component (may need to revert later)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stmontgomery @briancroom @grynspan