SwiftFixIt: Misc improvements #8671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it harder to make note vs. primary diagnostic mistakes in tests.
`joined()` already returns a lazy collection.
These diagnostics generally require user intervention.
AnthonyLatsis
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
bkhouri
reviewed
May 14, 2025
xedin
approved these changes
May 14, 2025
| case 0: | ||
| // No notes have fix-its. Skip if neither does the primary | ||
| // diagnostic. | ||
| guard diagnostic.hasFixIt else { |
There was a problem hiding this comment.
Hm, I wonder if we have cases where both a diagnostic and its notes have fix-its? If seems like if the diagnostic has fix-its we should use them since that should be considered a "default" behavior.
There was a problem hiding this comment.
Let’s find out. At first thought that sounds like something we’d want to discourage in favor of a note.
|
@swift-ci please test |
The minimum Swift tools version is appropriate for noncopyable types.
AnthonyLatsis
force-pushed
the
dia-especial
branch
from
0e8eddb to
3083a80
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
dschaefer2
approved these changes
May 16, 2025
xedin
pushed a commit
to xedin/swift-package-manager
that referenced
this pull request
May 22, 2025
### Modifications: * Test reorg. * More tests. * When we skip primary diagnostics, skip their notes too. * Skip primary diagnostics with more than 1 note with fix-its. * Deduplicate primary diagnostics. (cherry picked from commit 64b4746)
AnthonyLatsis
added a commit
that referenced
this pull request
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications: