[Commands] Migrate: Avoid injecting feature settings into every Swift… #8700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module Previously the feature flags in `:migrate` mode were injected globally into "destination" parameter and affected every module in the graph, this is technically harmless but creates a lot of noise and precludes some of the future optimizations i.e. avoid injecting `@concurrent` into some closure literals when context is already `@concurrent`. Instead of using build parameters, let's make the `Module.buildSettings` mutable in SwiftPM package and inject feature settings directly into `buildSettings` of the user-requested or all root package modules instead.
xedin
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test self hosted Windows platform |
dschaefer2
approved these changes
May 21, 2025
jakepetroules
approved these changes
May 21, 2025
xedin
added a commit
to xedin/swift-package-manager
that referenced
this pull request
May 22, 2025
swiftlang#8700) … module ### Motivation: Previously the feature flags in `:migrate` mode were injected globally into "destination" parameter and affected every module in the graph, this is technically harmless but creates a lot of noise and precludes some of the future optimizations i.e. avoid injecting `@concurrent` into some closure literals when context is already `@concurrent`. Instead of using build parameters, let's make the `Module.buildSettings` mutable in SwiftPM package and inject feature settings directly into `buildSettings` of the user-requested or all root package modules instead. ### Modifications: - Make `Module.buildSettings` to be a `package(set) var` instead of a `let` to allow for mutation my migration command. - Update `Migrate` command to inject the requested upcoming/experimental features in `:migrate` mode only into request targets or all non-plugin modules of root packages. ### Result: No more global build flags and extraneous warnings from dependency modules that shouldn't have migration enabled. (cherry picked from commit 297b487)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… module
Motivation:
Previously the feature flags in
:migratemode were injected globally into "destination" parameter and affected every module in the graph, this is technically harmless but creates a lot of noise and precludes some of the future optimizations i.e. avoid injecting@concurrentinto some closure literals when context is already@concurrent.Instead of using build parameters, let's make the
Module.buildSettingsmutable in SwiftPM package and inject feature settings directly intobuildSettingsof the user-requested or all root package modules instead.Modifications:
Module.buildSettingsto be apackage(set) varinstead of aletto allow for mutation my migration command.Migratecommand to inject the requested upcoming/experimental features in:migratemode only into request targets or all non-plugin modules of root packages.Result:
No more global build flags and extraneous warnings from dependency modules that shouldn't have migration enabled.