Skip to content

build-script: build static version of libdispatch #20793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

compnerd
Copy link
Member

build and install libdispatch static. We now build libdispatch using
CMake, which does not easily generate static and shared versions of
libraries. Create two builds to populate the toolchain distribution.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

@swift-ci please build toolchain

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-corelibs-libdispatch#433

@swift-ci please test

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-corelibs-libdispatch#433

@swift-ci please build toolchain

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - da94a8b44b451de9ab52f49e7147f3bfe441ee6b

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - da94a8b44b451de9ab52f49e7147f3bfe441ee6b

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-corelibs-libdispatch#433

@swift-ci please build toolchain

build and install libdispatch static.  We now build libdispatch using
CMake, which does not easily generate static and shared versions of
libraries.  Create two builds to populate the toolchain distribution.
@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift-corelibs-libdispatch#433

@swift-ci please build toolchain

@compnerd
Copy link
Member Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 022ade1 into swiftlang:master Nov 28, 2018
@compnerd compnerd deleted the static-libdispatch branch November 28, 2018 01:11
@@ -3282,6 +3286,11 @@ for host in "${ALL_HOSTS[@]}"; do
;;
esac
;;
libdispatch_static)
# FIXME: merge with libdispatch once the unit tests work with
Copy link
Contributor

@kevints kevints Nov 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue for this follow-up work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't create a SR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants