Migrate building SwiftSyntax to swift_build_support #27871
Conversation
ahoppen
force-pushed
the
swiftsyntax_build_support
branch
2 times, most recently
from
9f38bf5 to
aff7a5c
Compare
|
@swift-ci Please smoke test |
|
preset=buildbot_swiftsyntax_macos @swift-ci Please test with preset macOS Platform |
|
Great! The preset caught the generated files in SwiftSyntax being out-of-date. Let’s see if it passes now that the files have been updated. preset=buildbot_swiftsyntax_macos @swift-ci Please test with preset macOS Platform |
ahoppen
force-pushed
the
swiftsyntax_build_support
branch
from
aff7a5c to
46501b8
Compare
|
swiftlang/swift-syntax#160 |
|
swiftlang/swift-syntax#160 |
|
SwiftSyntax preset passed. Let’s try if SouceKit-LSP still builds since I touched its build script as well. swiftlang/swift-syntax#160 |
|
Building SourceKit-LSP also passed. https://ci.swift.org/job/swift-PR-osx-preset/60/ Let’s finally test the stress tester. swiftlang/swift-syntax#160 |
|
Mistakingly added a space after swiftlang/swift-syntax#160 |
|
swiftlang/swift-syntax#160 |
| @@ -101,8 +97,6 @@ KNOWN_SETTINGS=( | |||
| installable-package "" "the path to the archive of the installation directory" | |||
| test-installable-package "" "whether to run post-packaging tests on the produced package" | |||
| reconfigure "" "force a CMake configuration run even if CMakeCache.txt already exists" | |||
| build-libparser-only "" "only build libSwiftSyntaxParser" | |||
There was a problem hiding this comment.
Why are we removing --build-libparser-only? Isn't is still useful to be able to build the parser library without building the rest of the compiler? CC @akyrtzi
There was a problem hiding this comment.
This has been superseded by running utils/build-parser-lib
|
Cool! Is this ready to land? |
Related upstream patches: - swiftlang#27871 - swiftlang/swift-syntax#160
Related upstream patches: - #27871 - swiftlang/swift-syntax#160
It seems that build-libparser-only hasn't existed since 2019 and this change swiftlang#27871
It seems that build-libparser-only hasn't existed since 2019 and this change #27871
This migrates the build infrastructure of SwiftSyntax to
swift_build_support. It goes hand-in-hand with swiftlang/swift-syntax#160.