Skip to content

Remove invalid install_swiftsyntax_parser preset #41873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

keith
Copy link
Member

@keith keith commented Mar 17, 2022

It seems that build-libparser-only hasn't existed since 2019 and this
change #27871

It seems that build-libparser-only hasn't existed since 2019 and this
change swiftlang#27871
@keith keith requested a review from ahoppen March 17, 2022 23:11
@keith
Copy link
Member Author

keith commented Mar 17, 2022

@swift-ci please smoke test

@keith
Copy link
Member Author

keith commented Mar 17, 2022

@keith
Copy link
Member Author

keith commented Mar 18, 2022

@swift-ci please smoke test Linux Platform

@keith
Copy link
Member Author

keith commented Mar 18, 2022

@swift-ci please smoke test macOS Platform

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. I am not aware of any CI jobs building the parser library only.

@ahoppen
Copy link
Member

ahoppen commented Mar 18, 2022

@swift-ci Please smoke test Linux

@keith keith merged commit 333d2c2 into swiftlang:main Mar 18, 2022
@keith keith deleted the ks/remove-invalid-install_swiftsyntax_parser-preset branch March 18, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants