Skip to content

[Dependency Scanning] Record whether discovered binary Swift modules are frameworks #62540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Dec 13, 2022

This info is required so that it can be specified as input to compilation that uses such module as a dependency, in order to decide whether or not to insert an auto-linking directive for it.

Part of rdar://102824777

@artemcm
Copy link
Contributor Author

artemcm commented Dec 13, 2022

@swift-ci test

@artemcm artemcm force-pushed the BinaryExplicitDependencyIsFramework branch from c03f2ac to 7d568f0 Compare December 13, 2022 18:23
@artemcm
Copy link
Contributor Author

artemcm commented Dec 13, 2022

@artemcm artemcm marked this pull request as ready for review December 13, 2022 18:36
@artemcm artemcm requested review from nkcsgexi and owenv December 13, 2022 18:36
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artemcm artemcm force-pushed the BinaryExplicitDependencyIsFramework branch from 7d568f0 to 3db7678 Compare December 13, 2022 18:44
@artemcm
Copy link
Contributor Author

artemcm commented Dec 13, 2022

@artemcm artemcm merged commit 782e41b into swiftlang:main Dec 15, 2022
@artemcm artemcm deleted the BinaryExplicitDependencyIsFramework branch December 15, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants