Skip to content

[Concurrency] Custom executors with move-only Job #63569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 18, 2023
Merged

[Concurrency] Custom executors with move-only Job #63569

merged 9 commits into from
Mar 18, 2023

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Feb 10, 2023 •
edited
Loading

This is not cleaned up but it is exploring if we're able to pull off move-only Job and so far my conclusion is that we could! 🎉

DO NOT MERGE YET: Blocked on move-only being enabled for the stdlib:

@ktoso ktoso marked this pull request as draft February 10, 2023 11:40
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
ktoso
ktoso commented Feb 10, 2023
View reviewed changes
@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Feb 10, 2023
@benrimmington benrimmington mentioned this pull request Feb 12, 2023
Closed
@ktoso ktoso force-pushed the wip-custom-executors-moveonly-job branch from d3698cf to 814baea Compare February 16, 2023 11:44
@ktoso ktoso force-pushed the wip-custom-executors-moveonly-job branch from 814baea to b94aa07 Compare March 1, 2023 08:20
@ktoso
Copy link
Contributor Author

ktoso commented Mar 3, 2023

This will be unblocked by #64059

@ktoso ktoso changed the title [DNM][WIP] [Concurrency] Custom executors with move-only Job [Concurrency] Custom executors with move-only Job Mar 3, 2023
@ktoso ktoso force-pushed the wip-custom-executors-moveonly-job branch 2 times, most recently from 018b167 to a719119 Compare March 3, 2023 15:35
@ktoso ktoso requested a review from kavon March 3, 2023 15:37
@ktoso ktoso force-pushed the wip-custom-executors-moveonly-job branch from a719119 to 86d046b Compare March 3, 2023 16:18
@ktoso
Copy link
Contributor Author

ktoso commented Mar 3, 2023

Okey rebased updated and cleaned up... this is only waiting for the moveonly types to be enabled in stdlib and we will be able to remove the hardcoded flag and merge

@ktoso ktoso marked this pull request as ready for review March 10, 2023 03:57
@ktoso ktoso requested a review from xedin as a code owner March 10, 2023 03:58
@ktoso ktoso force-pushed the wip-custom-executors-moveonly-job branch 2 times, most recently from 95a420a to c6d5536 Compare March 16, 2023 12:02
@ktoso
Copy link
Contributor Author

ktoso commented Mar 16, 2023

@swift-ci please smoke test

ktoso
ktoso commented Mar 16, 2023
View reviewed changes
@ktoso ktoso force-pushed the wip-custom-executors-moveonly-job branch from c6d5536 to f1de11f Compare March 17, 2023 03:15
@ktoso
Copy link
Contributor Author

ktoso commented Mar 17, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 17, 2023

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@ktoso ktoso force-pushed the wip-custom-executors-moveonly-job branch from 07b77e0 to 443f95e Compare March 17, 2023 05:45
@ktoso
Copy link
Contributor Author

ktoso commented Mar 17, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 17, 2023

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@ktoso ktoso force-pushed the wip-custom-executors-moveonly-job branch from 3a7f106 to 443f95e Compare March 17, 2023 07:55
@ktoso
Copy link
Contributor Author

ktoso commented Mar 17, 2023

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please clean test with toolchain and preset

@ktoso
Copy link
Contributor Author

ktoso commented Mar 17, 2023 •
edited
Loading

Freestanding is somehow broken in wrongly reporting moveonly types are not available there -- paging @kavon to unblock this PR. rdar://106849189

@ktoso
Copy link
Contributor Author

ktoso commented Mar 17, 2023

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-custom-executors-moveonly-job branch from 795afbc to f61edfd Compare March 18, 2023 00:57
@ktoso
Copy link
Contributor Author

ktoso commented Mar 18, 2023

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please clean test with toolchain and preset

@ktoso
Copy link
Contributor Author

ktoso commented Mar 18, 2023

@swift-ci please smoke test

@ktoso ktoso merged commit e087759 into swiftlang:main Mar 18, 2023
@ktoso ktoso deleted the wip-custom-executors-moveonly-job branch March 20, 2023 02:56
@ktoso ktoso mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash mikeash left review comments

@kavon kavon Awaiting requested review from kavon

@AnthonyLatsis AnthonyLatsis Awaiting requested review from AnthonyLatsis AnthonyLatsis is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktoso @mikeash