Enable moveonly / noncopyable types by default #64106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test macos platform |
kavon
force-pushed
the
enable-moveonly-by-default
branch
4 times, most recently
from
084b639 to
195a219
Compare
|
@swift-ci please smoke test |
kavon
force-pushed
the
enable-moveonly-by-default
branch
from
195a219 to
746ab48
Compare
|
@swift-ci please smoke test |
kavon
force-pushed
the
enable-moveonly-by-default
branch
from
746ab48 to
77a0192
Compare
|
@swift-ci smoke test |
kavon
force-pushed
the
enable-moveonly-by-default
branch
from
a223dac to
924064e
Compare
|
@swift-ci please test |
|
@swift-ci smoke test |
kavon
force-pushed
the
enable-moveonly-by-default
branch
from
924064e to
7a8ee06
Compare
this pulls just the move checking passes out from behind the experimental flag.
Also removes some redundant checks in SILGen for the flag in order to process `_move` and `_borrow` that are already checked for in Sema. We will keep those behind the feature flag for now.
Since these types depend on lexical borrow scopes (a SIL option), we're now making that the requirement whenever such types appear.
The move checker was converting some kinds of copies into their `explicit_copy_*` versions, despite the type of the copy being a copyable type. This was causing random crashes in some narrow circumstances. resolves rdar://106669967
These are just basic restrictions for now to help avoid mistakes. The restrictions are inferred based on how the move checker uses these instructions.
kavon
force-pushed
the
enable-moveonly-by-default
branch
from
7a8ee06 to
ac60815
Compare
|
@swift-ci please test |
|
@swift-ci Please Test Source Compatibility |
kavon
force-pushed
the
enable-moveonly-by-default
branch
2 times, most recently
from
a4d0116 to
22472a8
Compare
kavon
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci please test |
doesn't seem to be a need to skip destroy hoisting anymore.
the main things still left behind the experimental flag(s) are - move-only classes (guarded by MoveOnlyClasses feature) - noimplicitcopy - the _borrow operator
kavon
force-pushed
the
enable-moveonly-by-default
branch
from
22472a8 to
2c7d9a5
Compare
|
@swift-ci please test |
|
@swift-ci Please Test Source Compatibility |
|
Wohoo, almost there! 🎉 🎉 🎉 |
|
Debug source compat failure is with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings move-only types (still via
@_moveOnly) out from behind the-enable-experimental-move-onlyflag. We still hold back features like@_noImplicitCopyand_borrow.resolves rdar://106669967&106314333