Skip to content

Build CMake 3.24.2 in Linux CI bots for main, next and rebranch #67018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2023
Merged

Build CMake 3.24.2 in Linux CI bots for main, next and rebranch #67018

merged 1 commit into from
Jul 7, 2023

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Jun 29, 2023

This would be needed to support the upcoming clang-1600 rebranch -- in there LLVM requires CMake 3.20 as per https://reviews.llvm.org/D151344

Note this will not take care of updating cmake_minimum_required in the build code -- we will consider doing this at a later time (possibly setting a different version that the one specified in update-checkout.config.json).

Addresses rdar://111475397

@edymtt edymtt requested a review from shahmishal as a code owner June 29, 2023 14:56
@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

@swift-ci Please Build Toolchain UBI9

@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

@swift-ci Please Build Toolchain CentOS 7

@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

@swift-ci Please Build Toolchain Amazon Linux 2

@shahmishal
Copy link
Member

Any reason to update older branch schemes?

@edymtt edymtt force-pushed the edymtt/use-cmake-3.24.2-in-ci-for-linux branch from 6584646 to c6d0f1b Compare June 29, 2023 15:16
@edymtt edymtt changed the title Build CMake 3.24.2 in Linux CI bots Build CMake 3.24.2 in Linux CI bots for main and next presets Jun 29, 2023
@edymtt
Build CMake 3.24.2 in Linux CI bots for main, next and rebranch
0617b16 
This would be needed to support the upcoming clang-1600 rebranch -- in
there LLVM requires CMake 3.20 as per https://reviews.llvm.org/D151344

Note this will not take care of updating `cmake_minimum_required` in the
build code -- we will consider doing this at a later time (possibly
setting a different version that the one specified in
`update-checkout.config.json`).

Addresses rdar://111475397
@edymtt edymtt force-pushed the edymtt/use-cmake-3.24.2-in-ci-for-linux branch from c6d0f1b to 0617b16 Compare June 29, 2023 15:17
@edymtt edymtt changed the title Build CMake 3.24.2 in Linux CI bots for main and next presets Build CMake 3.24.2 in Linux CI bots for main, next and rebranch Jun 29, 2023
@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023 •
edited
Loading

Good point, there is no reason -- I blindly run a search and replace on the file without thinking too much.

@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

@swift-ci Please Build Toolchain UBI9

@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

@swift-ci Please Build Toolchain CentOS 7

@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

@swift-ci Please Build Toolchain Amazon Linux 2

@edymtt edymtt mentioned this pull request Jun 29, 2023
Merged
@MaxDesiatov MaxDesiatov added cmake Linux Platform: Linux update-checkout Area → utils: the `update-checkout` script labels Jun 29, 2023
@edymtt
Copy link
Contributor Author

edymtt commented Jun 29, 2023

UBI 9 is failing test-sourcekit-lsp/test-sourcekit-lsp.py -- that seems an unrelated failure, since I see that in the nightly job as well

@edymtt
Copy link
Contributor Author

edymtt commented Jul 3, 2023

@swift-ci Please Build Toolchain UBI9

@edymtt
Copy link
Contributor Author

edymtt commented Jul 3, 2023

The issue hit in the UBI 9 toolchain job should be now addressed by #67082

@edymtt edymtt mentioned this pull request Jul 7, 2023
Closed
@shahmishal shahmishal merged commit b03d8df into swiftlang:main Jul 7, 2023
@edymtt edymtt deleted the edymtt/use-cmake-3.24.2-in-ci-for-linux branch July 7, 2023 15:55
@finagolfin finagolfin mentioned this pull request Jul 18, 2023
Merged
@futurejones futurejones mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

Assignees
No one assigned
Labels
cmake Linux Platform: Linux update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edymtt @shahmishal @MaxDesiatov