Skip to content

[SE-0456] Span properties #78561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Mar 24, 2025
Merged

[SE-0456] Span properties #78561

merged 24 commits into from
Mar 24, 2025

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Jan 10, 2025 •
edited
Loading

Implements most of the span properties proposed here, reviewed here, and accepted here.

Addresses most of rdar://137710901

Spans vended from InlineArray and CollectionOfOne are disabled at the moment.

span properties for String.UTF8View and Substring.UTF8View are added here.

@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard requested a review from DougGregor January 10, 2025 20:52
@glessard
Copy link
Contributor Author

@swift-ci please build toolchain

DougGregor
DougGregor approved these changes Jan 10, 2025
View reviewed changes
@glessard glessard force-pushed the rdar137710901-span-properties-prototype branch from cb2e4f9 to ff9805a Compare January 11, 2025 06:21
@glessard
Copy link
Contributor Author

@swift-ci please build toolchain

@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard force-pushed the rdar137710901-span-properties-prototype branch from ff9805a to 58c6395 Compare January 11, 2025 18:28
@glessard
Copy link
Contributor Author

@swift-ci please smoke test macOS platform

@glessard glessard force-pushed the rdar137710901-span-properties-prototype branch from 58c6395 to 72a6a26 Compare January 11, 2025 22:04
@glessard
Copy link
Contributor Author

@swift-ci please build toolchain

@glessard
Copy link
Contributor Author

@swift-ci please test linux platform

@DougGregor
Copy link
Member

@swift-ci please build toolchain Windows

@glessard
Copy link
Contributor Author

@swift-ci please build toolchain

@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard
Copy link
Contributor Author

@swift-ci please test macOS platform

@glessard glessard force-pushed the rdar137710901-span-properties-prototype branch 2 times, most recently from fed1d4f to 587640b Compare January 16, 2025 01:48
@glessard
Copy link
Contributor Author

@swift-ci please build toolchain

benrimmington
benrimmington reviewed Jan 16, 2025
View reviewed changes
@jckarter
Copy link
Contributor

jckarter commented Feb 4, 2025

@swift-ci Please test

benrimmington
benrimmington reviewed Feb 6, 2025
View reviewed changes
@natecook1000
Copy link
Member

@swift-ci Please build toolchain macOS platform

1 similar comment
@natecook1000
Copy link
Member

@swift-ci Please build toolchain macOS platform

@glessard glessard force-pushed the rdar137710901-span-properties-prototype branch 2 times, most recently from b697096 to e5505e9 Compare February 25, 2025 19:45
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard requested a review from DougGregor February 25, 2025 19:50
@glessard glessard marked this pull request as ready for review February 25, 2025 19:50
@glessard glessard requested a review from a team as a code owner February 25, 2025 19:50
@glessard glessard force-pushed the rdar137710901-span-properties-prototype branch from 6a7c8e2 to 940628a Compare March 10, 2025 23:01
@glessard
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard mentioned this pull request Mar 19, 2025
Merged
@glessard
Copy link
Contributor Author

@swift-ci please test

glessard
glessard commented Mar 20, 2025
View reviewed changes
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard
Copy link
Contributor Author

@swift-ci please test linux platform

@glessard
Copy link
Contributor Author

@swift-ci please test macOS platform

1 similar comment
@glessard
Copy link
Contributor Author

@swift-ci please test macOS platform

@glessard
Copy link
Contributor Author

@swift-ci please test linux platform

@glessard
Copy link
Contributor Author

@swift-ci please smoke test

@glessard glessard force-pushed the rdar137710901-span-properties-prototype branch from 8db28a6 to 7b03593 Compare March 22, 2025 00:27
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard
Copy link
Contributor Author

@swift-ci please test windows platform

@glessard glessard merged commit c21de06 into swiftlang:main Mar 24, 2025
5 checks passed
This was referenced Mar 25, 2025
Merged
Closed
This was referenced Apr 9, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benrimmington benrimmington benrimmington left review comments

@edymtt edymtt edymtt left review comments

@DougGregor DougGregor Awaiting requested review from DougGregor

@compnerd compnerd Awaiting requested review from compnerd compnerd is a code owner

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple justice-adams-apple is a code owner

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@glessard @DougGregor @jckarter @natecook1000 @benrimmington @etcwilde @edymtt