Skip to content

[SE-0456, -0467] enable span properties for inline-storage types #80257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Mar 25, 2025

Continues SE-0456 from #78561, continues SE-0467 from #79650.

Adds span and mutableSpan properties for CollectionOfOne and InlineArray.

UTF8View.span will be enabled for the small string representation in #80684

@glessard glessard requested a review from atrick March 25, 2025 00:50
@glessard glessard force-pushed the rdar137710901-addressable-span-properties branch from 5fcccf4 to 62eb7e0 Compare March 25, 2025 16:11
@glessard glessard marked this pull request as ready for review March 25, 2025 19:41
@glessard glessard requested a review from a team as a code owner March 25, 2025 19:41
@glessard glessard force-pushed the rdar137710901-addressable-span-properties branch from 62eb7e0 to 90752f9 Compare March 31, 2025 16:18
@glessard
Copy link
Contributor Author

glessard commented Apr 2, 2025

@swift-ci please test

@glessard glessard force-pushed the rdar137710901-addressable-span-properties branch 2 times, most recently from e9caab1 to 7a4df7f Compare April 4, 2025 21:35
@glessard glessard force-pushed the rdar137710901-addressable-span-properties branch from 7a4df7f to b8ed4af Compare April 4, 2025 21:51
@glessard glessard changed the title [SE-0456] enable span properties for inline-storage types [SE-0456, -0467] enable span properties for inline-storage types Apr 5, 2025
@glessard
Copy link
Contributor Author

glessard commented Apr 8, 2025

@swift-ci please test

@glessard glessard force-pushed the rdar137710901-addressable-span-properties branch from 4fd3c2b to 79fb06f Compare April 9, 2025 16:56
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glessard
Copy link
Contributor Author

glessard commented Apr 9, 2025

@swift-ci please test

@glessard glessard enabled auto-merge April 9, 2025 23:22
@glessard glessard merged commit 5c54e3a into swiftlang:main Apr 10, 2025
5 checks passed
@glessard glessard deleted the rdar137710901-addressable-span-properties branch April 29, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants