[Stdlib performance] Make integer conversion operations transparent #79707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please benchmark Apple Silicon |
|
@swift-ci please Apple Silicon benchmark |
Azoy
approved these changes
Feb 28, 2025
|
grrr, IR differences |
DougGregor
force-pushed
the
transparent-integer-conversions
branch
from
63678ab to
6282cf8
Compare
|
@swift-ci please smoke test |
|
@swift-ci please Apple Silicon benchmark |
Performance (arm64): -O
Code size: -O
Performance (arm64): -Osize
Code size: -Osize
Performance (arm64): -Onone
Code size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview |
DougGregor
requested review from
eeckstein,
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
j-hui and
fahadnayyar
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
OSLogOptimization pass The OSLogOptimization pass constant evaluates and folds SIL instructions that are inlined from the construction of the string interpolations passed to the log calls, which enables replacing the dynamic format string construction with a static format string. In addition to folding constant strings, it also folds constant integers and arrays whose elements are constants. This change makes it skip folding static strings, since they are already efficiently represented. rdar://146028438
The integer conversion operations were inlinable, but aren't getting inlined in debug builds, which results in unreasonably poor performance. Mark them as transparent so we don't end up with unspecialized generic code in the hot path. Fixes swiftlang#78501
DougGregor
force-pushed
the
transparent-integer-conversions
branch
from
a17cce1 to
c2417e0
Compare
|
@swift-ci please test |
|
Pulling in #79941 to test with it |
|
@swift-ci please test source compatibility |
Merged
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Apr 11, 2025
Revert "Merge pull request swiftlang#79707 from DougGregor/transparent-integer-conversions" This reverts commit 9c2c4ea, reversing changes made to 829e03c.
Merged
meg-gupta
added a commit
that referenced
this pull request
Apr 15, 2025
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Apr 19, 2025
Revert "Merge pull request swiftlang#80767 from meg-gupta/reverttransparent" This reverts commit 198a802, reversing changes made to 8eb43af.
Merged
meg-gupta
added a commit
that referenced
this pull request
Apr 21, 2025
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Apr 21, 2025
Revert "Merge pull request swiftlang#80767 from meg-gupta/reverttransparent" This reverts commit 198a802, reversing changes made to 8eb43af.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integer conversion operations were inlinable, but aren't getting inlined in debug builds, which results in unreasonably poor performance. Mark them as transparent so we don't end up with unspecialized generic code in the hot path.
Fixes #78501