[SILOpt][OSLog] Skip constant folding StaticString in the OSLogOptimization pass #79941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSLogOptimization pass The OSLogOptimization pass constant evaluates and folds SIL instructions that are inlined from the construction of the string interpolations passed to the log calls, which enables replacing the dynamic format string construction with a static format string. In addition to folding constant strings, it also folds constant integers and arrays whose elements are constants. This change makes it skip folding static strings, since they are already efficiently represented. rdar://146028438
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci please test Windows |
|
Windows tests passed in #79707 |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OSLogOptimization pass constant evaluates and folds SIL instructions that are inlined from the construction of the string interpolations passed to the log calls, which enables replacing the dynamic format string construction with a static format string. In addition to folding constant strings, it also folds constant integers and arrays whose elements are constants. This change makes it skip folding static strings, since they are already efficiently represented.
This patch unblocks #79707
cc @DougGregor