Skip to content

[Distributed] Minor test cleanup #80664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

[Distributed] Minor test cleanup #80664

merged 1 commit into from
Apr 9, 2025

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 9, 2025

Minor cleanup.

Unsure why the test can't find the resolvable macro on some CI jobs hmmm

rdar://148741109

@ktoso
Copy link
Contributor Author

ktoso commented Apr 9, 2025

@swift-ci please test

@@ -86,12 +88,6 @@
// UNSUPPORTED: back_deployment_runtime
// UNSUPPORTED: remote_run || device_run


// FIXME: Also reproduces the following issue rdar://128284016
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we solved this

@@ -12,7 +12,7 @@
// RUN: -Xfrontend -validate-tbd-against-ir=all \
// RUN: -o %t/%target-library-name(FakeDistributedActorSystems)

/// Build the Lib
/// Build the ResilientAPILib
// RUN: %target-build-swift \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro plugin path is already set here and that's the only file using the macro... so I'm not sure what's wrong here.

@ktoso ktoso enabled auto-merge April 9, 2025 01:44
@ktoso
Copy link
Contributor Author

ktoso commented Apr 9, 2025

@swift-ci please smoke test

@ktoso ktoso merged commit 961cfb8 into swiftlang:main Apr 9, 2025
4 of 5 checks passed
@ktoso ktoso deleted the wip-cleanup branch April 10, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants