Skip to content

[Distributed] Minor test cleanup #80664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

[Distributed] Minor test cleanup #80664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions test/Distributed/Runtime/distributed_actor_remoteCall_accessibleFunctions_crossModule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// RUN: -Xfrontend -validate-tbd-against-ir=all \
// RUN: -o %t/%target-library-name(FakeDistributedActorSystems)

/// Build the Lib
/// Build the ResilientAPILib
// RUN: %target-build-swift \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro plugin path is already set here and that's the only file using the macro... so I'm not sure what's wrong here.

// RUN: -target %target-swift-6.0-abi-triple \
// RUN: -parse-as-library -emit-library \
Expand All @@ -27,14 +27,15 @@
// RUN: -Xfrontend -validate-tbd-against-ir=all \
// RUN: -o %t/%target-library-name(ResilientAPILib)

/// Build the ActorLib
/// Build the ResilientImplLib
// RUN: %target-build-swift \
// RUN: -target %target-swift-6.0-abi-triple \
// RUN: -parse-as-library -emit-library \
// RUN: -emit-module-path %t/ResilientImplLib.swiftmodule \
// RUN: -module-name ResilientImplLib \
// RUN: -I %t \
// RUN: -L %t \
// RUN: -plugin-path %swift-plugin-dir \
// RUN: %t/src/ResilientImplLib.swift \
// RUN: -lFakeDistributedActorSystems \
// RUN: -lResilientAPILib \
Expand All @@ -52,6 +53,7 @@
// RUN: -module-name main \
// RUN: -I %t \
// RUN: -L %t \
// RUN: -plugin-path %swift-plugin-dir \
// RUN: %s \
// RUN: -enable-library-evolution \
// RUN: -Xfrontend -validate-tbd-against-ir=all \
Expand Down Expand Up @@ -86,12 +88,6 @@
// UNSUPPORTED: back_deployment_runtime
// UNSUPPORTED: remote_run || device_run


// FIXME: Also reproduces the following issue rdar://128284016
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we solved this

//<unknown>:0: error: symbol '$s15ResilientAPILib30ServiceProtocolP8getArray2a12a2SayAA8ResponseVGSaySiG_SSSgtYaKFTj' (dispatch thunk of ResilientAPILib.ServiceProtocol.getArray(a1: Swift.Array<Swift.Int>, a2: Swift.Optional<Swift.String>) async throws -> Swift.Array<ResilientAPILib.Response>) is in generated IR file, but not in TBD file

//<unknown>:0: error: symbol '$s15ResilientAPILib30ServiceProtocolP8getArray2a12a2SayAA8ResponseVGSaySiG_SSSgtYaKFTjTu' (async function pointer to dispatch thunk of ResilientAPILib.ServiceProtocol.getArray(a1: Swift.Array<Swift.Int>, a2: Swift.Optional<Swift.String>) async throws -> Swift.Array<ResilientAPILib.Response>) is in generated IR file, but not in TBD file

//--- ResilientAPILib.swift

import Distributed
Expand Down