Skip to content

[silgen] Fix a small typo bug I found on inspection. #80952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

We are performing a cast instead of a dyn_cast in an if statement. This will assert on failure rather than fall through. It seems to be an obvious typo. I checked in the actual commit in question that introduced it and the intention was to be a dyn_cast.

rdar://149698148

We are performing a cast instead of a dyn_cast in an if statement. This will
assert on failure rather than fall through. It seems to be an obvious typo. I
checked in the actual commit in question that introduced it and the intention
was to be a dyn_cast.

rdar://149698148
@gottesmm gottesmm requested a review from jckarter as a code owner April 21, 2025 17:40
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm requested a review from nate-chandler April 21, 2025 17:40
Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM--Thank you!

@gottesmm gottesmm enabled auto-merge April 21, 2025 19:57
@gottesmm gottesmm merged commit e9253b7 into swiftlang:main Apr 21, 2025
3 checks passed
@gottesmm gottesmm deleted the pr-fed954ec5197ef80d86a4c4e9c9ca2de9ad8687a branch April 21, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants