[6.2][silgen] Fix a small typo bug I found on inspection. #80970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are performing a cast instead of a dyn_cast in an if statement. This will assert on failure rather than fall through. It seems to be an obvious typo. I checked in the actual commit in question that introduced it and the intention was to be a dyn_cast. rdar://149698148 (cherry picked from commit 132eb93)
gottesmm
changed the title
|
@swift-ci test |
|
@swift-ci test macOS platform |
tbkka
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: While looking at making some changes in ResultPlan.cpp, I noticed
that we were performing:
which is very suspicious since cast<> fails on failure rather than failing like
a dyn_cast would. After reviewing the git history, I discovered that this was
clearly a thinko where dyn_cast was actually meant to be used:
Scope: Just converts a cast that was meant to be a dyn_cast to actually be a
dyn_cast.
Resolves: rdar://149698148
Main PR: #80952
Risk: Low.
Testing: N/A. Correct on sight.
Reviewer: @nate-chandler