Skip to content

🍒 [6.2][cxx-interop] Fix a CI failure in ptrauth test #80955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

j-hui
Copy link
Contributor

@j-hui j-hui commented Apr 21, 2025

Explanation: #80495 was merged to main to fix an issue, and was followed up by #80638 to fix a platform-specific test case. #80495 was cherry-picked to release/6.2 in #80586; this PR cherry-picks the test case fix from #80638. Fixes the CI failure here.
Issue: rdar://149683618
Risk: Low, the only change is targeted a platform-specific regression test.
Testing: Fixes a test
Original PR: #80638
Reviewer: @j-hui (myself)

I'm cherry-picking this on behalf of @Xazax-hun (author of the original PR) because UK folks are on holiday.

This test is not executed by the pre-commit CI, so the failure went
unnoticed after #80495. This PR updates the test to make the CI pass.

rdar://148665873
(cherry picked from commit c0b1fa1)
@j-hui j-hui requested a review from a team as a code owner April 21, 2025 18:26
@j-hui
Copy link
Contributor Author

j-hui commented Apr 21, 2025

@swift-ci please test

@j-hui j-hui enabled auto-merge April 21, 2025 18:51
@j-hui
Copy link
Contributor Author

j-hui commented Apr 21, 2025

Unrelated test failure. Going to try testing again in case it is a flakey one

@j-hui
Copy link
Contributor Author

j-hui commented Apr 21, 2025

@swift-ci please test macos platform

@j-hui j-hui merged commit c8e9da9 into release/6.2 Apr 22, 2025
5 checks passed
@j-hui j-hui deleted the j-hui/release/6.2/ptrauth-ci-test-fix branch April 22, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants