Fixed Symfony 4.3 deprecated messages

[XWB]

This should resolve the following errors:

The getReachableRoles() method of the RoleHierarchyInterface is deprecated
The getRoles() method of the TokenInterface is deprecated

[nicolas-grekas]

I'd suggest removing the full dobclock here, it doesn't provide enough value.

[XWB]

@nicolas-grekas Done.

[nicolas-grekas]

Thank you @XWB.

[Andrej-in-ua]

https://github.com/symfony/security-core/blob/4.2/Role/RoleHierarchy.php#L41
getReachableRoles expected array of RoleInterface. Array of string given.
I think $roles = $this->getRoleNames($token); need move into condition if (method_exists($this->roleHierarchy, 'getReachableRoleNames')) {

[nicolas-grekas]

Can you please send a PR if there's something to fix?

[Andrej-in-ua]

Thanks for the quick reply. Yes, of course, I’m doing it right now...

[XWB]

@Andrej-in-ua That might trigger another deprecation warning. I think changing the getRoleNames method should do the trick.

You can try to change this:

    private function getRoleNames(TokenInterface $token): array
    {
        if (method_exists($token, 'getRoleNames')) {
            return $token->getRoleNames();
        }
        // Symfony < 4.3 BC layer
        return array_map(function (Role $role) {
            return $role->getRole();
        }, $token->getRoles());
    }

Into this:

    private function getRoleNames(TokenInterface $token): array
    {
        if (method_exists($token, 'getRoleNames')) {
            return $token->getRoleNames();
        }

        return $token->getRoles();
    }

?

[Andrej-in-ua]

@XWB In this case, we will rely on the fact that if there is a method getRoleNames exists, then there will definitely exists getReachableRoleNames. I do not know all the nuances so well. But if you confirm that it is ok, then I do PR.
At least right after I deal with the tests :/

In my project both solution worked.