Skip to content

Fixed Symfony 4.3 wrong role variable type #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Andrej-in-ua
Copy link
Contributor

This should fix work in symfony < 4.3

Original error from logs symfony 3.4 application:

Uncaught PHP Exception Symfony\Component\Debug\Exception\FatalThrowableError:
"Call to a member function getRole() on string" at
vendor/symfony/symfony/src/Symfony/Component/Security/Core/Role/RoleHierarchy.php line 41
{"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0):
Call to a member function getRole() on string at
vendor/symfony/symfony/src/Symfony/Component/Security/Core/Role/RoleHierarchy.php:41

Found in #50 (comment)

@nicolas-grekas nicolas-grekas force-pushed the andrej-in-ua/s43-wrong-role-type branch from 617a8ae to 489dc66 Compare December 12, 2019 09:55
@nicolas-grekas
Copy link
Member

Thank you @Andrej-in-ua.

nicolas-grekas added a commit that referenced this pull request Dec 12, 2019
This PR was merged into the 3.0-dev branch.

Discussion
----------

Fixed Symfony 4.3 wrong role variable type

This should fix work in symfony < 4.3

Original error from logs symfony 3.4 application:
```
Uncaught PHP Exception Symfony\Component\Debug\Exception\FatalThrowableError:
"Call to a member function getRole() on string" at
vendor/symfony/symfony/src/Symfony/Component/Security/Core/Role/RoleHierarchy.php line 41
{"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0):
Call to a member function getRole() on string at
vendor/symfony/symfony/src/Symfony/Component/Security/Core/Role/RoleHierarchy.php:41
```

Found in #50 (comment)

Commits
-------

489dc66 Fixed Symfony 4.3 wrong role variable type
@nicolas-grekas nicolas-grekas merged commit 489dc66 into symfony:master Dec 12, 2019
@Andrej-in-ua Andrej-in-ua deleted the andrej-in-ua/s43-wrong-role-type branch December 12, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants