Fix adding custom extensions for unit testing #6463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure if it wasn't better to properly set up the validator extension here instead of mocking things away. |
|
What do others think about this? |
This was referenced Aug 3, 2016
linaori
reviewed
Oct 16, 2016
| ->getMock(); | ||
| $validator | ||
| ->method('getMetadataFor') | ||
| ->will($this->returnValue($metadata)); |
There was a problem hiding this comment.
Could actually be ->willReturn($metadata);
|
Sorry @natanael89 for not merging your PR earlier. Unfortunately, we merged #7941 in the meantime so there's no need for this PR anymore. I hope to see you soon again with some other changes though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version was generating the following error when running tests:
The changes for vesion 2.8+ should be a little different due to the refactoring that took place, but I would be happy to fix it once this gets merged.