Skip to content

Added a help note about the __toString() method in User classes #6837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Member

This partially fixes #6463.

@xabbuh
Copy link
Member

xabbuh commented Aug 3, 2016

👍

Status: Reviewed

@weaverryan
Copy link
Member

@javiereguiluz I don't think you linked the right issue. Why should we add this?

@wouterj
Copy link
Member

wouterj commented Aug 21, 2016

@weaverryan correct issue is #6574

I'm still 👎 for the same reasons:

  • You implement UserInterface, so it's never converted to a string.
  • The whole concept of allowing to pass a string, UserInterface or object with __toString() is just too bad to even talk about. I'll submit a WIP PR this week to the code repository to remove this. In sort, all objects used as user just need to implement UserInterface, let's forget about the objects that can be converted to a string.

@weaverryan
Copy link
Member

@wouterj I understand your point... in fact, I understand it so well, that I can't figure out what the bug/problem was in the original #6574 that this was fixing?

@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

So what do you here?

@javiereguiluz
Copy link
Member Author

Closing it because doc voters don't agree with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants