Add note about LocaleListener #8411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocaleListener uses information provided by Request object. Setting it after LocaleListener read the object results in no effect.
translation/locale.rst
Outdated
|
|
||
| Using a listener like this requires that it is called **before** | ||
| LocaleListener attempts to access it. In Symfony Framework it is called | ||
| with priority 8 by default. You will need to set your event listener |
There was a problem hiding this comment.
Better not to write the priority number if it changes
Just talk about defining the listener with a higher priority than the locale one
There was a problem hiding this comment.
Updated accordingly. Thanks.
javiereguiluz
approved these changes
Jan 4, 2018
|
Thank you @Steveb-p. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 5, 2018
This PR was merged into the 3.3 branch. Discussion ---------- Add note about LocaleListener LocaleListener uses information provided by Request object. Setting your own Listener, which is supposed to change request object locale, without priority results in LocaleListener already having it's locale set up and not reacting at all. This change adds this warning to documentation. Commits ------- 531909d Reword 1492f3e Remove information about default priority 52681f4 Fix missing blank line 03de10f Add note about LocaleListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocaleListener uses information provided by Request object.
Setting your own Listener, which is supposed to change request object locale, without priority results in LocaleListener already having it's locale set up and not reacting at all. This change adds this warning to documentation.