Skip to content

Add note about LocaleListener #8411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2018
Merged

Add note about LocaleListener #8411

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03de10f
Add note about LocaleListener
Steveb-p Sep 20, 2017
52681f4
Fix missing blank line
Steveb-p Sep 20, 2017
1492f3e
Remove information about default priority
Steveb-p Sep 27, 2017
531909d
Reword
javiereguiluz Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions translation/locale.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ it::
$request->setLocale($locale);
}

.. note::

Using a listener like this requires that it is called **before**
LocaleListener attempts to access it. In Symfony Framework it is called
with priority 8 by default. You will need to set your event listener
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not to write the priority number if it changes
Just talk about defining the listener with a higher priority than the locale one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated accordingly. Thanks.

with a higher one if you want this to work.

Read :doc:`/session/locale_sticky_session` for more information on making
the user's locale "sticky" to their session.

Expand Down