Revamped the reference/events.rst article #8649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Nov 15, 2017
weaverryan
added a commit
that referenced
this pull request
Nov 16, 2017
This PR was squashed before being merged into the 2.7 branch (closes #8649). Discussion ---------- Revamped the reference/events.rst article While upgrading some contents yesterday, I realized that this article is not as good as it should be, considering how important it is. The changes I propose: * For each event, clearly explain when it's dispatched and what you can do with it (without duplicating the full explanations found in `components/http_kernel.rst`) * Remove the tables showing the list of listeners/subscribers for each event. This is too hard to maintain and it depends on the components installed in your application. Let's mention the `debug:event-dispatcher` command instead. The last change is important because the information provided currently is wrong. See for example the Symfony Demo app:  Commits ------- 9703922 Fixed RST syntax issue dff597e Revamped the reference/events.rst article
weaverryan
added a commit
that referenced
this pull request
Nov 16, 2017
|
Great job! I like the update and I really like the removal of unnecessary/duplicated information. |
weaverryan
added a commit
that referenced
this pull request
Nov 21, 2017
* 2.7: Some fixes for testing/* articles in 2.7 docs Fixed some issues in PHPUnit XML config examples Removed a wrong note about controllers as services Removed lots of redundant contents [#8650] Minor rewording [#8649] Small reword Improved the link to the Symfony events reference Minor fixes for upload_file.rst Fixed a typo Added getSubscribedEvents() to UserLocaleSubscriber Reworded the explanation about service tags Reworded the intro of reference/dic_tags.rst Fixed RST syntax issue Revamped the reference/events.rst article Change some docs to be gender-neutral
weaverryan
added a commit
that referenced
this pull request
Nov 21, 2017
* 2.8: Some fixes for testing/* articles in 2.7 docs Fixed some issues in PHPUnit XML config examples Removed a wrong note about controllers as services Removed lots of redundant contents [#8650] Minor rewording [#8649] Small reword Improved the link to the Symfony events reference Minor fixes for upload_file.rst Fixed a typo Added getSubscribedEvents() to UserLocaleSubscriber Reworded the explanation about service tags Reworded the intro of reference/dic_tags.rst Fixed RST syntax issue Revamped the reference/events.rst article Change some docs to be gender-neutral
weaverryan
added a commit
that referenced
this pull request
Nov 21, 2017
* 3.3: (34 commits) Removed a deprecated feature in a testing article Some fixes for testing/* articles in 2.7 docs A few tiny encore tweaks Fixed some issues in PHPUnit XML config examples Minor typos in session articles Removed a wrong note about controllers as services Removed lots of redundant contents fix typo Update micro_kernel_trait.rst Update micro_kernel_trait.rst [#8650] Minor rewording [#8649] Small reword Improved the link to the Symfony events reference Minor fixes for upload_file.rst added commas for php code section [Workflow] minor tweaks Fixed a typo Fix minor typo Added getSubscribedEvents() to UserLocaleSubscriber [Config] Add missing paranthesis of `arrayPrototype` method ...
weaverryan
added a commit
that referenced
this pull request
Nov 21, 2017
* 3.4: (34 commits) Removed a deprecated feature in a testing article Some fixes for testing/* articles in 2.7 docs A few tiny encore tweaks Fixed some issues in PHPUnit XML config examples Minor typos in session articles Removed a wrong note about controllers as services Removed lots of redundant contents fix typo Update micro_kernel_trait.rst Update micro_kernel_trait.rst [#8650] Minor rewording [#8649] Small reword Improved the link to the Symfony events reference Minor fixes for upload_file.rst added commas for php code section [Workflow] minor tweaks Fixed a typo Fix minor typo Added getSubscribedEvents() to UserLocaleSubscriber [Config] Add missing paranthesis of `arrayPrototype` method ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading some contents yesterday, I realized that this article is not as good as it should be, considering how important it is.
The changes I propose:
components/http_kernel.rst)debug:event-dispatchercommand instead.The last change is important because the information provided currently is wrong. See for example the Symfony Demo app: