Skip to content

Reworded the intro of reference/dic_tags.rst #8650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2017

Conversation

javiereguiluz
Copy link
Member

If you don't agree with the title change, I'll revert it. Thanks!

service that you would like to register as a listener to one of Symfony's
core events, you can flag it with the ``kernel.event_listener`` tag.
:doc:`Service tags </service_container/tags>` are the mechanism used by the
:doc:`Dependency Injection component </components/dependency_injection>` to flag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DependencyInjection component

@weaverryan weaverryan merged commit 6e43fb7 into symfony:2.7 Nov 16, 2017
weaverryan added a commit that referenced this pull request Nov 16, 2017
This PR was squashed before being merged into the 2.7 branch (closes #8650).

Discussion
----------

Reworded the intro of reference/dic_tags.rst

If you don't agree with the title change, I'll revert it. Thanks!

Commits
-------

6e43fb7 Fixed a typo
f1e5f2a Reworded the intro of reference/dic_tags.rst
@weaverryan
Copy link
Member

Even though I'm accustomed to the old name, I think this new title/name is unmistakably better :)

weaverryan added a commit that referenced this pull request Nov 16, 2017
weaverryan added a commit that referenced this pull request Nov 21, 2017
* 2.7:
  Some fixes for testing/* articles in 2.7 docs
  Fixed some issues in PHPUnit XML config examples
  Removed a wrong note about controllers as services
  Removed lots of redundant contents
  [#8650] Minor rewording
  [#8649] Small reword
  Improved the link to the Symfony events reference
  Minor fixes for upload_file.rst
  Fixed a typo
  Added getSubscribedEvents() to UserLocaleSubscriber
  Reworded the explanation about service tags
  Reworded the intro of reference/dic_tags.rst
  Fixed RST syntax issue
  Revamped the reference/events.rst article
  Change some docs to be gender-neutral
weaverryan added a commit that referenced this pull request Nov 21, 2017
* 2.8:
  Some fixes for testing/* articles in 2.7 docs
  Fixed some issues in PHPUnit XML config examples
  Removed a wrong note about controllers as services
  Removed lots of redundant contents
  [#8650] Minor rewording
  [#8649] Small reword
  Improved the link to the Symfony events reference
  Minor fixes for upload_file.rst
  Fixed a typo
  Added getSubscribedEvents() to UserLocaleSubscriber
  Reworded the explanation about service tags
  Reworded the intro of reference/dic_tags.rst
  Fixed RST syntax issue
  Revamped the reference/events.rst article
  Change some docs to be gender-neutral
weaverryan added a commit that referenced this pull request Nov 21, 2017
* 3.3: (34 commits)
  Removed a deprecated feature in a testing article
  Some fixes for testing/* articles in 2.7 docs
  A few tiny encore tweaks
  Fixed some issues in PHPUnit XML config examples
  Minor typos in session articles
  Removed a wrong note about controllers as services
  Removed lots of redundant contents
  fix typo
  Update micro_kernel_trait.rst
  Update micro_kernel_trait.rst
  [#8650] Minor rewording
  [#8649] Small reword
  Improved the link to the Symfony events reference
  Minor fixes for upload_file.rst
  added commas for php code section
  [Workflow] minor tweaks
  Fixed a typo
  Fix minor typo
  Added getSubscribedEvents() to UserLocaleSubscriber
  [Config] Add missing paranthesis of `arrayPrototype` method
  ...
weaverryan added a commit that referenced this pull request Nov 21, 2017
* 3.4: (34 commits)
  Removed a deprecated feature in a testing article
  Some fixes for testing/* articles in 2.7 docs
  A few tiny encore tweaks
  Fixed some issues in PHPUnit XML config examples
  Minor typos in session articles
  Removed a wrong note about controllers as services
  Removed lots of redundant contents
  fix typo
  Update micro_kernel_trait.rst
  Update micro_kernel_trait.rst
  [#8650] Minor rewording
  [#8649] Small reword
  Improved the link to the Symfony events reference
  Minor fixes for upload_file.rst
  added commas for php code section
  [Workflow] minor tweaks
  Fixed a typo
  Fix minor typo
  Added getSubscribedEvents() to UserLocaleSubscriber
  [Config] Add missing paranthesis of `arrayPrototype` method
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants