Skip to content

Reworded the note about supressing form validation #8940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2017

Conversation

javiereguiluz
Copy link
Member

This replaces #6461 according to reviewer's comments.

@HeahDude please check if this PR is correct according to your comment here: #6461 (comment)

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@weaverryan
Copy link
Member

Awesome :)

@weaverryan weaverryan merged commit cb823f7 into symfony:2.7 Dec 30, 2017
weaverryan added a commit that referenced this pull request Dec 30, 2017
…guiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Reworded the note about supressing form validation

This replaces #6461 according to reviewer's comments.

@HeahDude please check if this PR is correct according to your comment here: #6461 (comment)

Commits
-------

cb823f7 Reworded the note about supressing form validation
@wouterj
Copy link
Member

wouterj commented Dec 31, 2017

Can we please keep a note/caution directive stating that this does not disable extra field or file upload size handling?

@weaverryan
Copy link
Member

@wouterj can you open a pr or issue - I honestly don’t understand enough about all the details to know for sure about your question

@HeahDude
Copy link
Contributor

HeahDude commented Jan 1, 2018

See #8956.

javiereguiluz added a commit that referenced this pull request Jan 2, 2018
…eguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Fixed invalid form validation reference

Continue #8940.

Commits
-------

2af182d Reword
2b904b7 Fixed invalid form validation reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants