Skip to content

Fixed invalid form validation reference #8956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2018
Merged

Fixed invalid form validation reference #8956

merged 2 commits into from
Jan 2, 2018

Conversation

HeahDude
Copy link
Contributor

@HeahDude HeahDude commented Jan 1, 2018

Continue #8940.

@HeahDude HeahDude added the Form label Jan 1, 2018
@HeahDude HeahDude added this to the 2.7 milestone Jan 1, 2018
@HeahDude HeahDude changed the base branch from master to 2.7 January 1, 2018 17:10
@HeahDude HeahDude mentioned this pull request Jan 1, 2018
Merged
@HeahDude HeahDude force-pushed the fix-form-validation branch from dd0f57d to 2b904b7 Compare January 1, 2018 17:14
javiereguiluz
javiereguiluz approved these changes Jan 2, 2018
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeahDude thanks! It looked OK to me, but I'm proposing a reword. If you disagree, please revert my changes.

@HeahDude
Copy link
Contributor Author

HeahDude commented Jan 2, 2018

👍

@javiereguiluz
Copy link
Member

Thanks Jules.

@javiereguiluz javiereguiluz merged commit 2af182d into symfony:2.7 Jan 2, 2018
javiereguiluz added a commit that referenced this pull request Jan 2, 2018
@javiereguiluz
minor #8956 Fixed invalid form validation reference (HeahDude, javier…
b86e2f4 
…eguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Fixed invalid form validation reference

Continue #8940.

Commits
-------

2af182d Reword
2b904b7 Fixed invalid form validation reference
@HeahDude HeahDude deleted the fix-form-validation branch January 3, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@wouterj wouterj wouterj approved these changes

@weaverryan weaverryan Awaiting requested review from weaverryan

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@HeahDude @javiereguiluz @wouterj @carsonbot