Skip to content

Use packaging for LegacyVersion / LooseVersion #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

tony
Copy link
Member

@tony tony commented Jan 14, 2022

Ongoing issue:

  • python 3.10 raises warnings with distutils

  • In packaging, LegacyVersion (the supercessor to LooseVersion) will be deprecated, we won't be able to support 2.4-openbsd (like what is seen on OpenBSD's tmux versions

    This deprecation warning is live in 21.3 and looks like it will have LegacyVersion removed in 22

      /home/t/work/python/libtmux/.venv/lib/python3.10/site-packages/packaging/version.py:127: 
        DeprecationWarning: Creating a LegacyVersion has been deprecated and will be removed in the next major release
        warnings.warn(
    
    -- Docs: https://docs.pytest.org/en/stable/warnings.html
    

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #349 (d556084) into master (5f66a68) will increase coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head d556084 differs from pull request most recent head 9306d46. Consider uploading reports for the commit 9306d46 to get more accurate results

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   87.68%   87.88%   +0.19%     
==========================================
  Files          20       16       -4     
  Lines        1852     1519     -333     
  Branches      298        0     -298     
==========================================
- Hits         1624     1335     -289     
- Misses        154      184      +30     
+ Partials       74        0      -74     
Impacted Files Coverage Δ
libtmux/common.py 86.86% <100.00%> (ø)
tests/test_common.py 98.26% <100.00%> (+0.82%) ⬆️
tests/test_version.py 100.00% <100.00%> (ø)
tests/test_pane.py 100.00% <0.00%> (ø)
tests/test_server.py 100.00% <0.00%> (ø)
tests/test_tmuxobject.py 100.00% <0.00%> (ø)
src/libtmux/pytest_plugin.py
src/libtmux/test.py
src/libtmux/pane.py
src/libtmux/window.py
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the tn-distutils-packaging branch 3 times, most recently from d556084 to 910344d Compare January 15, 2022 16:57
@tony tony changed the title Use packaging for Version Use packaging for LegacyVersion / LooseVersion Jan 15, 2022
@tony tony mentioned this pull request Jan 15, 2022
@tony tony force-pushed the tn-distutils-packaging branch from 910344d to f8c3e38 Compare February 26, 2022 17:38
@tony tony force-pushed the master branch 2 times, most recently from bb68b70 to d6ab13b Compare July 14, 2022 10:33
@tony tony force-pushed the tn-distutils-packaging branch from f8c3e38 to 5a7f573 Compare December 10, 2022 14:47
@tony tony force-pushed the tn-distutils-packaging branch from 5a7f573 to 9306d46 Compare December 10, 2022 19:50
tony added a commit that referenced this pull request Dec 10, 2022
Deprecate distutils.version.LooseVersion for our own LegacyVersion

Fixes #348, #349

See also: tmux-python/tmuxp#727
@tony
Copy link
Member Author

tony commented Dec 10, 2022

Resolved via e3e6c39 (#351)

@tony tony closed this Dec 10, 2022
@tony tony deleted the tn-distutils-packaging branch December 10, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant