-
Notifications
You must be signed in to change notification settings - Fork 109
Use packaging
for LegacyVersion
/ LooseVersion
#349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
+ Coverage 87.68% 87.88% +0.19%
==========================================
Files 20 16 -4
Lines 1852 1519 -333
Branches 298 0 -298
==========================================
- Hits 1624 1335 -289
- Misses 154 184 +30
+ Partials 74 0 -74
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d556084
to
910344d
Compare
packaging
for Version
packaging
for LegacyVersion
/ LooseVersion
910344d
to
f8c3e38
Compare
bb68b70
to
d6ab13b
Compare
f8c3e38
to
5a7f573
Compare
We still need those to work - not to break pypi conformance, but since we use this for tmux versions.
5a7f573
to
9306d46
Compare
tony
added a commit
that referenced
this pull request
Dec 10, 2022
Deprecate distutils.version.LooseVersion for our own LegacyVersion Fixes #348, #349 See also: tmux-python/tmuxp#727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing issue:
python 3.10 raises warnings with distutils
In
packaging
,LegacyVersion
(the supercessor toLooseVersion
) will be deprecated, we won't be able to support2.4-openbsd
(like what is seen on OpenBSD's tmux versionsThis deprecation warning is live in 21.3 and looks like it will have
LegacyVersion
removed in 22