Skip to content

Use packaging for Version #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

tony
Copy link
Member

@tony tony commented Jan 15, 2022

Compare to #349

@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #352 (d0cac1b) into master (5f66a68) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head d0cac1b differs from pull request most recent head 799c13e. Consider uploading reports for the commit 799c13e to get more accurate results

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   87.68%   87.81%   +0.12%     
==========================================
  Files          20       15       -5     
  Lines        1852     1510     -342     
  Branches      298        0     -298     
==========================================
- Hits         1624     1326     -298     
- Misses        154      184      +30     
+ Partials       74        0      -74     
Impacted Files Coverage Δ
libtmux/common.py 86.86% <100.00%> (ø)
tests/test_common.py 98.26% <100.00%> (+0.82%) ⬆️
tests/test_pane.py 100.00% <0.00%> (ø)
tests/test_server.py 100.00% <0.00%> (ø)
tests/test_tmuxobject.py 100.00% <0.00%> (ø)
src/libtmux/window.py
src/libtmux/common.py
src/libtmux/server.py
src/libtmux/__init__.py
src/libtmux/test.py
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ssbarnea
ssbarnea previously approved these changes Dec 9, 2022
@ssbarnea
Copy link
Contributor

ssbarnea commented Dec 9, 2022

@tony Any chance to revive this. Those deprecation warnings are really annoying.

@tony
Copy link
Member Author

tony commented Dec 9, 2022

@ssbarnea Yes, it is top priority. In the next two or three weeks (for this and tmuxp)

@tony tony force-pushed the tn-distutils-packaging-version branch from d0cac1b to dfecd4a Compare December 10, 2022 14:42
@tony tony force-pushed the tn-distutils-packaging-version branch from dfecd4a to 799c13e Compare December 10, 2022 19:50
@tony
Copy link
Member Author

tony commented Dec 10, 2022

@ssbarnea

This was resolved via e3e6c39 (#351)

It will be live in 0.16.0, on PyPI now at 0.16.0a1

@tony
Copy link
Member Author

tony commented Dec 10, 2022

@ssbarnea Now live in v0.16.0 v0.16.1

Let me know how this works for you!

Closing this issue per now via e3e6c39 (#351) + 8d433b2 (#461)

@tony tony closed this Dec 10, 2022
@tony tony deleted the tn-distutils-packaging-version branch December 10, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants