Refinement #266
Merged
Refinement #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Problem ------- Compound type with refinement (structural type with a parent) doesn't parse. Solution -------- This adds support for it. It collides with context bounds `A: B: C`, so the precedence is set to -1.
eed3si9n
commented
May 29, 2023
| @@ -3,9 +3,9 @@ | |||
| # This is an integration test to generally check the quality of parsing. | |||
|
|
|||
| SCALA_SCALA_LIBRARY_EXPECTED=95 | |||
| SCALA_SCALA_COMPILER_EXPECTED=84 | |||
| SCALA_SCALA_COMPILER_EXPECTED=87 | |||
There was a problem hiding this comment.
Scala 2 compiler bumps to 87% with this change.
ckipp01
approved these changes
May 29, 2023
| DOTTY_COMPILER_EXPECTED=81 | ||
| SYNTAX_COMPLEXITY_CEILING=2300 | ||
| SYNTAX_COMPLEXITY_CEILING=2800 |
There was a problem hiding this comment.
Do we have an idea of how much is too much here? Like when should it cause refactoring to account for the bump?
There was a problem hiding this comment.
I guess when we observe compilation time or memory usage to degrade?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265
Problem
Compound type with refinement (structural type with a parent) doesn't parse.
Solution
This adds support for it.
It collides with context bounds
A: B: C, so the precedence is set to -1.