-
Notifications
You must be signed in to change notification settings - Fork 58
Refinement #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refinement #266
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,9 +3,9 @@ | |
# This is an integration test to generally check the quality of parsing. | ||
|
||
SCALA_SCALA_LIBRARY_EXPECTED=95 | ||
SCALA_SCALA_COMPILER_EXPECTED=84 | ||
SCALA_SCALA_COMPILER_EXPECTED=87 | ||
DOTTY_COMPILER_EXPECTED=81 | ||
SYNTAX_COMPLEXITY_CEILING=2300 | ||
SYNTAX_COMPLEXITY_CEILING=2800 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we have an idea of how much is too much here? Like when should it cause refactoring to account for the bump? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess when we observe compilation time or memory usage to degrade? |
||
|
||
if [ ! -d "$SCALA_SCALA_DIR" ]; then | ||
echo "\$SCALA_SCALA_DIR must be set" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scala 2 compiler bumps to
87%
with this change.