Polyfill Element#getAttributeNames.
#393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinfagnani, isn't there some attribute ordering problem with IE11? Does this polyfill need to address that? |
There's no way to address this since the ordering is lost during parsing. We're already robust to ordering changes when using |
|
|
||
| if (!Element_prototype.hasOwnProperty('getAttributeNames')) { | ||
| Element_prototype.getAttributeNames = function getAttributeNames(this: Element): Array<string> { | ||
| return map.call(getAttributes.call(this), attr => attr.name) as Array<string>; |
There was a problem hiding this comment.
Instead of storing the .attributes getter, why not just call this.attributes here?
There was a problem hiding this comment.
It's just so that this won't call into anything else that might wrap the attributes getter after this polyfill is applied.
justinfagnani
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a polyfill for
Element#getAttributeNames.