-
Notifications
You must be signed in to change notification settings - Fork 169
Polyfill Element#getAttributeNames
.
#393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ee7402e
Polyfill `Element#getAttributeNames`.
bicknellr 377a7db
Update changelog.
bicknellr 5027a8e
In IE11, the `attributes` descriptor is on `Node.prototype`.
bicknellr 8e0ce38
Fix Safari 9 and Chrome 41.
bicknellr 5aecfa1
Merge remote-tracking branch 'origin/master' into get-attribute-names
bicknellr 4fce7c2
Merge remote-tracking branch 'origin/master' into get-attribute-names
bicknellr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
<!doctype html> | ||
<!-- | ||
@license | ||
Copyright (c) 2020 The Polymer Project Authors. All rights reserved. | ||
This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt | ||
The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt | ||
The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt | ||
Code distributed by Google as part of the polymer project is also | ||
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt | ||
--> | ||
<html> | ||
<head> | ||
<title>Element getAttributeNames</title> | ||
<script src="../node_modules/@webcomponents/webcomponentsjs/bundles/webcomponents-pf_dom.js"></script> | ||
<script src="./wct-config.js"></script> | ||
<script src="../node_modules/wct-browser-legacy/browser.js"></script> | ||
</head> | ||
<body> | ||
<script> | ||
suite('Element getAttributeNames', function() { | ||
test('Returns an array of attribute names', () => { | ||
const element = document.createElement('div'); | ||
assert(element.getAttributeNames().length === 0); | ||
|
||
let attributeNames; | ||
|
||
attributeNames = element.getAttributeNames(); | ||
assert.isArray(attributeNames); | ||
assert.deepEqual(attributeNames, []); | ||
|
||
element.setAttribute('name-a', 'value-a'); | ||
attributeNames = element.getAttributeNames(); | ||
assert.deepEqual(attributeNames, ['name-a']); | ||
|
||
element.setAttribute('name-b', 'value-b'); | ||
attributeNames = element.getAttributeNames(); | ||
assert.deepEqual(attributeNames, ['name-a', 'name-b']); | ||
|
||
element.removeAttribute('name-a'); | ||
attributeNames = element.getAttributeNames(); | ||
assert.deepEqual(attributeNames, ['name-b']); | ||
|
||
element.removeAttribute('name-b'); | ||
attributeNames = element.getAttributeNames(); | ||
assert.deepEqual(attributeNames, []); | ||
}); | ||
}); | ||
</script> | ||
</body> | ||
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
packages/webcomponentsjs/ts_src/platform/get-attribute-names.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/** | ||
@license | ||
Copyright (c) 2020 The Polymer Project Authors. All rights reserved. | ||
This code may only be used under the BSD style license found at | ||
http://polymer.github.io/LICENSE.txt The complete set of authors may be found at | ||
http://polymer.github.io/AUTHORS.txt The complete set of contributors may be | ||
found at http://polymer.github.io/CONTRIBUTORS.txt Code distributed by Google as | ||
part of the polymer project is also subject to an additional IP rights grant | ||
found at http://polymer.github.io/PATENTS.txt | ||
*/ | ||
|
||
export {}; | ||
|
||
const Element_prototype = Element.prototype; | ||
// In IE11, the `attributes` descriptor is on `Node.prototype`. | ||
const attributesDescriptor = | ||
Object.getOwnPropertyDescriptor(Element_prototype, 'attributes') ?? | ||
Object.getOwnPropertyDescriptor(Node.prototype, 'attributes'); | ||
// In Safari 9, the `attributes` descriptor's getter is undefined. In Chrome 41, | ||
// the `attributes` descriptor is a data descriptor on each Element instance. | ||
const getAttributes = attributesDescriptor?.get ?? | ||
function(this: Element) { return this.attributes; }; | ||
const map = Array.prototype.map; | ||
|
||
if (!Element_prototype.hasOwnProperty('getAttributeNames')) { | ||
Element_prototype.getAttributeNames = function getAttributeNames(this: Element): Array<string> { | ||
return map.call(getAttributes.call(this), attr => attr.name) as Array<string>; | ||
}; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of storing the
.attributes
getter, why not just callthis.attributes
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just so that this won't call into anything else that might wrap the
attributes
getter after this polyfill is applied.