Skip to content

Add check for escaped brackets in levelpos calculation #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

cbcoutinho
Copy link

Really simple way to fix #532

@cbcoutinho
Copy link
Author

@phy1729 Could you comment on these tests so far? I'm not sure how to test the difference between single quotes and double quotes. I'm also unclear how you implement the multi-line test from your comment as well

@phy1729
Copy link
Member

phy1729 commented Sep 30, 2018

I'd use single quotes instead of dollar quotes (e.g. BUFFER='echo (x\])'), but that's just style.

What I was trying to convey before was instead of adding conditionals in brackets-highlighter.zsh, you could add under line 56 or so

\\)
(( SOME_VAR )) && pos++
;;

where SOME_VAR is a placeholder for a variable a user could set to opt-in to the behavior (or opt-out. I don't use the brackets highlighter, so I don't have a strong opinion on what the default should be.)

@danielshahaf
Copy link
Member

@cbcoutinho Why close this?

@cbcoutinho
Copy link
Author

cbcoutinho commented Oct 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escaped bracket not ignored
3 participants