fix(tabs): scale the contents of mat-tab-group to the group's height #9180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Fixes a couple of instances that were missed when removing the slider deletion targets.
* Adds the `FlexibleConnectedPositionStrategy` that builds on top of the `ConnectedPositionStrategy` adds the following: * The ability to have overlays with flexible sizing. * Being able to push overlays into the viewport if they don't fit. * Having a margin between the overlay and the viewport edge. * Being able to assign weights to the overlay positions. * Refactors the `ConnectedPositionStrategy` to use the `FlexibleConnectedPositionStrategy` in order to avoid breaking API changes. * Switches all of the components to the new position strategy. * Adds an API to the `OverlayRef` that allows for the consumer to wrap the pane in a div. This is a common requirement between the `GlobalPositionStrategy` and the `FlexibleConnectedPositionStrategy`, and it's easier to keep track of the elements when the attaching and detaching is done in the `OverlayRef`. Fixes #6534. Fixes #2725. Fixes #5267.
Removes the 6.0.0 deletion targets from `material/list`. BREAKING CHANGES: * `selectionChange` on the `MatListOption`, which was deprecated in 5.0.0 has been removed. Use `selectionChange` on the `MatSelectionList` instead. * `MatListOptionChange` which was deprecated in 5.0.0 has been removed.
Removes the `material/icon` deletion targets for 6.0.0. BREAKING CHANGES: * The `_document` parameter in the `MatIconRegistry` constructor is now required.
Removes the `SHOW_ANIMATION` and `HIDE_ANIMATION` variables from the snack bar which were being exported all the way up to `@angular/material` and were implying that these are generic show and hide animations. BREAKING CHANGES: * `SHOW_ANIMATION` has been removed. * `HIDE_ANIMATION` has been removed.
* fix(schematics): better formatting on index, insert body margin 0 * fix(schematics): fix wrong mode on init * fix(schemtic): convert == to === * fix(schematic): fix check expression * chore: pr feedback
Fixes the aot CI check failing due to a faulty rebase.
Re-wording of the 1st sentence in ###. I guess this is the correct meaning of what was wanted.
Fixes a couple of positioning unit test failures on iOS Safari after the switch to the flexible connected position. The issue appears to be a combination of us stubbing out the `ScrollDispatcher` for all tests which means that if one test scrolls the window down, any subsequent tests won't pick up the scroll position correctly, as well as having a test that scrolls the page down, but doesn't reset it. These changes: * Reset the position back to the top after the scrolling test is done. * Rework the tests to only stub out the `ScrollDispatcher` in the two tests where it's relevant.
* feat(cdk): switch injectables to new scope API * Update rxjs version * Update CDK to new API * Fix TS 2.7 error. * Update package lock
Removes the deletion targets for 6.0.0 from the `material/button-toggle` entry point. BREAKING CHANGES: * `selected` is no longer an input and is now readonly.
Removes the deletion targets for 6.0.0 from `material/datepicker`. BREAKING CHANGES: * `selectedChanged` has been removed. Use `dateChange` or `dateInput` from `MatDatepickerInput`.
Makes the `_ngZone` parameter in `CdkTextareaAutosize` a required one. This was intended as a deletion target, but we hadn't set up deletion targets when it was added. BREAKING CHANGES: * The `_ngZone` parameter in the `CdkTextareaAutosize` constructor is now required.
* Fixes the badge transition not working due to the `transition` declaration being invalid (no units on the duration). * Fixes the badge animating all properties rather than only the `transform`. * Avoids blurry text in IE.
Switches the autofill monitor to run outside the `NgZone`, because it toggles classes on the element directly and it has the potential of being fired very often if the user has other animations on the element. Also adds a description to an output that is part of the public API.
…0305) * With the async call around the checks in the layout test, the results of the subscribe are never actually checked
Removes a typography variable that's been deprecated for a while. BREAKING CHANGES: * The `$mat-font-family` variable has been removed. Use the Material typography or redeclare in your project `$mat-font-family: Roboto, 'Helvetica Neue', sans-serif;`.
* Currently buttons with a background color (e.g. flat buttons, raised buttons, fabs) receive a font color by the theme. This font color is accidentally being overwritten by the normal button CSS that sets the `color` for every button to `inherit`. This can cause the text to be invisible in a dark theme. From now on, those buttons will no longer inherit the font color accidentally. * Normal buttons, stroked buttons and icon buttons will still inherit the font color, because it's wrong to assume that those buttons are always placed inside of containers with the default background color. Otherwise those buttons would be invisible in some containers with a different background color (e.g. in a themed toolbar). * Removes the SSR check for `hasHostAttributes`. This method is essential for the color of the buttons, and needs to run inside of SSR. (now possible with Domino anyway) * Cleans up the button theme while being at it. Fixes #4614. Fixes #9231. Fixes #9634
Adds support for stretched tabs in the tab nav bar. Also removes a duplicate selector. Fixes #8871.
…s is provided (#10462) In the `FlexibleConnectedPositionStrategy` once we apply a position, we save a reference to it in order to be able to reuse it if the consumer wants to recalculate the overlay dimensions, however that cached position isn't being cleared. This means that if consumer were to provide a new set of positions and tried to re-apply the last calculated position, the cached position may no longer be a part of the list of preferred positions. These changes will clear the last position if it's not a part of the preferred positions anymore. Relates to #10457.
…olled and content is flowing upwards (#10463) * Fixes the bounding box position and height being calculated incorrectly when the overlay's content is flowing upwards and the page has been scrolled down. * Fixes the "when scrolled" tests not scrolling the page down.
Fixes an error that prevented the e2e tests from running due to the badge not being included in the SystemJS config.
Fixes the `.mat-flat-card` selector not working due to its specificity being too low. Fixes #11014.
…ayKeyboardDispatcher (#10807) Currently when dispatching events through the `OverlayKeyboardDispatcher` we try to match one of the overlays to the element that triggered the event. This is problematic, because some components will open an overlay, but will keep focus on the trigger element (e.g. `mat-autocomplete` and `mat-select`). These changes switch the logic so the keyboard events are always dispatched to the top-level overlay. Fixes #10799.
* chore(demo): add examples to demo app * fix aot
#11037) * docs(form-field): update documentation regarding label and placeholder * address comments
|
Is there any reason why the PR hasn't still been merged after 5 months? |
|
My apologies, this slipped by on my radar as I was working on a few other parts of core and Material. The change looks good to me, but I'm going to run it through the internal Google test suite to confirm that it doesn't cause any unexpected changes. |
|
Looks like all tests pass except one, which was due to a weird assumption with a floating element in the tab content. Once that is fixed, we can get this ready for merge. In the meantime, can you rebase the change? |
added 2 commits
May 26, 2018 11:11
CDDelta
requested review from
amcdnl,
crisbeto,
devversion,
jelbourn,
josephperrott,
mmalerba and
tinayuangao
as code owners
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
googlebot
added
cla: no
|
Damn, I messed up the rebase. Still a noob. I will open another pull request and close this. Sorry! |
|
#11520 is the replacement PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the fix by @RobJacobs to correctly scale the contents of
mat-tab-groupto the group's height.Fixes #4591