This repository was archived by the owner on Aug 1, 2023. It is now read-only.
[#345] logging configuration for logging to file #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Diemand <[email protected]>
ksaric
force-pushed
the
345-logs-in-file
branch
from
a52658a to
0d63a1e
Compare
ksaric
reviewed
Nov 12, 2019
There was a problem hiding this comment.
Not sure about the "Logs/launcher" and the scName/FileSK::, but if that is the intention...
The example config can be found here - https://github.com/input-output-hk/cardano-shell/blob/master/cardano-launcher/configuration/launcher/jormungandr/launcher-config-qa.linux.yaml#L6
Signed-off-by: Alexander Diemand <[email protected]>
Signed-off-by: Alexander Diemand <[email protected]>
Signed-off-by: Alexander Diemand <[email protected]>
CodiePP
force-pushed
the
345-logs-in-file
branch
from
8714de9 to
394b6e2
Compare
Signed-off-by: Alexander Diemand <[email protected]>
…-shell into 345-logs-in-file
ksaric
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
LGTM, beside the error when I run it:
$> stack exec cardano-launcher -- --config ./cardano-launcher/configuration/launcher/jormungandr/launcher-config-qa.linux.yaml --wallet-exit-codes "[CLIExitCodeFailure 21, CLIExitCodeFailure 22, CLIExitCodeFailure 20, CLIExitCodeSuccess]" --updater-exit-codes "[CLIExitCodeFailure 1, CLIExitCodeSuccess]"
LauncherCLI {launcherConfigPath = LauncherOptionPath {getLauncherOptionPath = "./cardano-launcher/configuration/launcher/jormungandr/launcher-config-qa.linux.yaml"}, walletExitCodes = Just [CLIExitCodeFailure 21,CLIExitCodeFailure 22,CLIExitCodeFailure 20,CLIExitCodeSuccess], updaterExitCodes = Just [CLIExitCodeFailure 1,CLIExitCodeSuccess]}
cannot remove symlink: /home/ksaric/.local/share/Daedalus/qa/Logs/launcher
exception: /home/ksaric/.local/share/Daedalus/qa/Logs/launcher: removeLink: does not exist (No such file or directory)
The:
cannot remove symlink: /home/ksaric/.local/share/Daedalus/qa/Logs/launcher
exception: /home/ksaric/.local/share/Daedalus/qa/Logs/launcher: removeLink: does not exist (No such file or directory)
|
opened issue: input-output-hk/iohk-monitoring-framework#452 |
disassembler
added a commit
that referenced
this pull request
Mar 28, 2020
ksaric
added a commit
that referenced
this pull request
Apr 1, 2020
* tlsConfig passed via launcherConfig * Revert "[#345] logging configuration for logging to file (#350)" This reverts commit 975e880. * Temporarily disable the certificate tests. Co-authored-by: ksaric <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the logging configuration to log to a file
needs: access to the configuration argument:
launcherLogsPrefix