tlsConfig passed via launcherConfig #359
Conversation
disassembler
requested review from
erikd,
ksaric and
oneEdoubleD
as code owners
| @@ -77,7 +72,7 @@ main = silence $ do | |||
|
|
|||
| -- This function either stubs out the wallet exit code or | |||
| -- returns the "real" function. | |||
| let walletExecutionFunction = | |||
| let walletExectionFunction = | |||
There was a problem hiding this comment.
why do you want to rename this function?
There was a problem hiding this comment.
it's a revert of the entire commit that's failing to work on windows. Fully agree that the other name is better, but I don't have the time or expertise to fix the failures we were getting on windows with this commit. I did a bisect and found this was the culprit.
There was a problem hiding this comment.
The only thing I can do for now is disable these tests, since the way it was reconfigured it to run sort of makes the whole certificate test unnecessary.
At this stage, this is the best we can do - the confirmation that it actually runs correctly on the system.
If this is going to be used in the future, the tests should be re-enabled and re-written correctly.
|
bors r+ |
This PR changes tlsConfig to be an attribute in the launcher config instead of being a separate configuration file. We've tested it with daedalus flight and can confirm tls certificates are generated. This probably breaks tests.