Skip to content

Deliver changes from Contribution Day #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Mar 30, 2018
Merged

Deliver changes from Contribution Day #63

merged 28 commits into from
Mar 30, 2018

Conversation

okolesnyk
Copy link
Member

@okolesnyk okolesnyk commented Mar 22, 2018

Description

To verify basic Framework functionality I want to be able to create and run MFTF tests without any other projects required.
Included Pull Requests from Contribution Day. Please refer to issues to get more info about.

Fixed Issues (if relevant)

  1. Resolve Add "block" type to list of existing section element types #56: Add "block" type to list of existing section element types
  2. Resolve Debug flag exists in robo generate:tests to print action sequence of test steps #57: Debug flag exists in robo generate:tests to print action sequence of test steps
  3. Resolve Allow browser type to be configured in env file #58: Allow browser type to be configured in env file
  4. Resolve Build interactive configuration tool for populating .env properties #60: Build interactive configuration tool for populating .env properties
  5. Resolve Validate build:project was run before attempting to generate tests #61: Validate build:project was run before attempting to generate tests

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Mar 22, 2018

CLA assistant check
All committers have signed the CLA.

@magento magento deleted a comment from coveralls Mar 23, 2018
@magento magento deleted a comment from coveralls Mar 23, 2018
RoboFile.php Outdated
*
* @return void
*/
function functional()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This robo command did not work as expected.

@tomreece tomreece self-assigned this Mar 23, 2018
@tomreece tomreece added accept and removed accept labels Mar 23, 2018
@tomreece tomreece self-requested a review March 23, 2018 16:24
@okolesnyk okolesnyk changed the title Make possible to create and run MFTF test in framework Deliver changes from Contribution Day Mar 29, 2018
@@ -0,0 +1,99 @@
<?php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a similar type of class as a 3rd party library, why did we write a new one?

Copy link
Contributor

@imeron2433 imeron2433 Mar 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed, future implementation will get rid of this dependency.

@okolesnyk okolesnyk merged commit bf24553 into develop Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment